Skip to content

feat(gateway): add delete commands - #1901

Open
aidandaly24 wants to merge 4 commits into
feat/gateway-update-cudfrom
feat/gateway-delete-cud
Open

feat(gateway): add delete commands#1901
aidandaly24 wants to merge 4 commits into
feat/gateway-update-cudfrom
feat/gateway-delete-cud

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add Gateway, Target, connector-backed Target, and Rule delete commands
  • keep Gateway deletion non-cascading and delegate dependency enforcement to the service
  • implement Connector delete as a Target facade that verifies the selected Target is connector-backed before deletion
  • keep Gateway, Target, and Rule Core methods as direct SDK command mappings

IAM scope

  • this PR does not mutate execution-role permissions or delete IAM roles
  • execution-role ownership and cleanup remain deferred to the shared IAM management plane

Stack

Testing

  • focused command registration, selector validation, Connector classification, and Core SDK mapping tests
  • fixture-backed Rule, Target, Connector, and Gateway deletion through the real router and Core
  • Delete fixtures contain only Connector preflight/Get and Delete SDK exchanges; prerequisites are provisioned directly only while recording
  • live recording with AWS_PROFILE=e2e-test verified asynchronous deletion and cleanup of the disposable Gateway and IAM role
  • full Gateway suite, build, lint, formatting, and changed-file type checks

This was referenced Aug 4, 2026
Open
Open
@github-actions github-actions Bot added the size/l PR size: L label Aug 4, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress size/l PR size: L and removed size/l PR size: L agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from c539d87 to 346da50 Compare August 4, 2026 14:08
@github-actions github-actions Bot added size/l PR size: L and removed size/l PR size: L labels Aug 4, 2026
@github-actions github-actions Bot added size/l PR size: L and removed size/l PR size: L labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from 346da50 to 3ae4e1c Compare August 4, 2026 14:22
@github-actions github-actions Bot added size/l PR size: L and removed size/l PR size: L labels Aug 4, 2026
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from 3ae4e1c to 178d3f8 Compare August 4, 2026 16:59
@aidandaly24 aidandaly24 mentioned this pull request Aug 4, 2026
Closed
@codecov-commenter

codecov-commenter commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.83%. Comparing base (f6e7737) to head (c23c894).

Additional details and impacted files 
@@                     Coverage Diff                     @@
##           feat/gateway-update-cud    #1901      +/-   ##
===========================================================
+ Coverage                    95.80%   95.83%   +0.03%     
===========================================================
  Files                          300      304       +4     
  Lines                        17414    17556     +142     
===========================================================
+ Hits                         16683    16825     +142     
  Misses                         731      731

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch 2 times, most recently from d6338db to a57a894 Compare August 4, 2026 18:21
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from a57a894 to e9aaf30 Compare August 4, 2026 18:32
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch 2 times, most recently from 2c5417f to b819e5f Compare August 4, 2026 19:55
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from b819e5f to 17c5548 Compare August 5, 2026 15:54
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from 17c5548 to 8e7db89 Compare August 5, 2026 17:48
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch 2 times, most recently from 5358067 to 84a1b94 Compare August 6, 2026 23:16
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch 2 times, most recently from 1cb0275 to c1d8290 Compare August 7, 2026 17:15
@aidandaly24
aidandaly24 force-pushed the feat/gateway-delete-cud branch from 37518f6 to d543f8b Compare August 7, 2026 17:54
@aidandaly24
aidandaly24 marked this pull request as ready for review August 7, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/l PR size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidandaly24 @codecov-commenter